Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve manual relay #250

Merged
merged 19 commits into from
Mar 2, 2023
Merged

Improve manual relay #250

merged 19 commits into from
Mar 2, 2023

Conversation

canhtrinh
Copy link
Collaborator

this PR fixes #175. it's an update to PR: #245 that was accidentally merged

the issue was in the manualRelayToDestChain method, which was eagerly attempting to confirm every tx hash without first checking whether the tx has already been confirmed on the network.

the issue that comes up with cannot sign command comes up for transactions that were already confirmed but the batch has not been broadcasted to the destination chain.

this fix:

  • first checks to see whether the transaction was executed/approved/confirmed.
  • if already executed/approved, do nothing
  • if already confirmed, attempt to extract the commandId and query the batchedCommandID from the axelarscan API. then check if the commandID in that batched has not been executed, and execute if need be.
  • otherwise, do as before.

@canhtrinh canhtrinh merged commit cf7bd4d into v0.12.5 Mar 2, 2023
@canhtrinh canhtrinh deleted the improveManualRelay branch March 2, 2023 20:12
canhtrinh added a commit that referenced this pull request Mar 17, 2023
* chore: fix wrong min_gas_price calculation (#243)

* chore: fix wrong min_gas_price calculation

* chore: rename param

* chore: use wei

* chore: improve doc

* chore: add tests

* [feature][draft] subscribeToTx (#241)

* chore: initial commit

* feat: 'working' wss

* 0.12.5-alpha.1

* refactor: polymorphic subscribeToTx

* chore: serialize menssage instead of interpolating string

* chore: remove ws dependency

* 0.12.5-alpha.2

* chore: update changelog

---------

Co-authored-by: Canh Trinh <[email protected]>

* chore: fix arbitrum

* 0.12.5-alph.3

* Update package (#249)

* feat:add repo to package.json for link on npm (#248)

Hopefully adding a repository link here will get the "repository" link to show up on npm here:  https://www.npmjs.com/package/@axelar-network/axelarjs-sdk/

* Update package

* Fix wording in readme

---------

Co-authored-by: Stephen Fluin <[email protected]>

* Improve manual relay (#250)

* chore: setting up calc for generating command ID

chore: code cleanup

* chore: update manual relay to destination chain

* chore: code cleanup

* chore: code cleanup

* chore: adding comments

* chore: adding event query

* chore: adding query methods for confirmation height and event

* chore: code cleanup

* chore: code refactor

* chore: typo in changelog

* chore: refactor code and update tests

* chore: fixing command ID calculation

chore: fixing issue where event initially not found

chore: adding retry on retrieving batch data

chore: adding retries

chore: code cleanup

* chore: code cleanup

* chore: code cleanup

* chore: code cleanup for manualRelay through signing

* chore: adding logs for debug mode

* chore: update command ID and update tests

* Erc20 deposit address (#251)

* feat: add erc 20 deposit address initial commit

* chroe: wip

* chore: update tests

* chore: update tests

* chore: PR comment for local binding of refundAddress

* chore: update changelog

* 0.12.5-alpha.4

* chore: adding BNBCHAIN

* chore: gmpe treatment

* chore: update subtractNativeGasFee to not subtract gas already paid

* chore: update changelog

* 0.12.5-alpha.5

* chore: updating express fee calculation (#254)

* chore: adding a fix to addNativeGasMethod with overestimation (#253)

* chore: adding a fix to addNativeGasMethod with overestimation

* chore: code cleanup

* 0.12.5-alpha.6

* chore: fix aurora symbol

* 0.12.5-alpha.7

* fix: adding expressFee to fee param

* 0.12.5-alpha.8

* chore: code cleanup and adding base to testnet

* chore: fix date of v0.12.5 in changelog

* 0.12.5

---------

Co-authored-by: npty <[email protected]>
Co-authored-by: Alan Soares <[email protected]>
Co-authored-by: Jon Ator <[email protected]>
Co-authored-by: Stephen Fluin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants