chore: adding a fix to addNativeGasMethod with overestimation #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npty
reviewed
Mar 14, 2023
| const txStatus: GMPStatusResponse | undefined = await this.queryTransactionStatus(txHash).catch( | ||
| () => undefined | ||
| ); | ||
| return [GMPStatus.SRC_GATEWAY_CONFIRMED, GMPStatus.DEST_GATEWAY_APPROVED].includes( |
There was a problem hiding this comment.
what does SRC_GATEWAY_CONFIRMED mean?
There was a problem hiding this comment.
status is confirmed. but we translate that to the use (via parseGMPStatus) to be more descriptive to read source_gateway_confirmed instead.
npty
approved these changes
Mar 14, 2023
pjenviri
approved these changes
Mar 14, 2023
canhtrinh
added a commit
that referenced
this pull request
Mar 17, 2023
* chore: fix wrong min_gas_price calculation (#243) * chore: fix wrong min_gas_price calculation * chore: rename param * chore: use wei * chore: improve doc * chore: add tests * [feature][draft] subscribeToTx (#241) * chore: initial commit * feat: 'working' wss * 0.12.5-alpha.1 * refactor: polymorphic subscribeToTx * chore: serialize menssage instead of interpolating string * chore: remove ws dependency * 0.12.5-alpha.2 * chore: update changelog --------- Co-authored-by: Canh Trinh <[email protected]> * chore: fix arbitrum * 0.12.5-alph.3 * Update package (#249) * feat:add repo to package.json for link on npm (#248) Hopefully adding a repository link here will get the "repository" link to show up on npm here: https://www.npmjs.com/package/@axelar-network/axelarjs-sdk/ * Update package * Fix wording in readme --------- Co-authored-by: Stephen Fluin <[email protected]> * Improve manual relay (#250) * chore: setting up calc for generating command ID chore: code cleanup * chore: update manual relay to destination chain * chore: code cleanup * chore: code cleanup * chore: adding comments * chore: adding event query * chore: adding query methods for confirmation height and event * chore: code cleanup * chore: code refactor * chore: typo in changelog * chore: refactor code and update tests * chore: fixing command ID calculation chore: fixing issue where event initially not found chore: adding retry on retrieving batch data chore: adding retries chore: code cleanup * chore: code cleanup * chore: code cleanup * chore: code cleanup for manualRelay through signing * chore: adding logs for debug mode * chore: update command ID and update tests * Erc20 deposit address (#251) * feat: add erc 20 deposit address initial commit * chroe: wip * chore: update tests * chore: update tests * chore: PR comment for local binding of refundAddress * chore: update changelog * 0.12.5-alpha.4 * chore: adding BNBCHAIN * chore: gmpe treatment * chore: update subtractNativeGasFee to not subtract gas already paid * chore: update changelog * 0.12.5-alpha.5 * chore: updating express fee calculation (#254) * chore: adding a fix to addNativeGasMethod with overestimation (#253) * chore: adding a fix to addNativeGasMethod with overestimation * chore: code cleanup * 0.12.5-alpha.6 * chore: fix aurora symbol * 0.12.5-alpha.7 * fix: adding expressFee to fee param * 0.12.5-alpha.8 * chore: code cleanup and adding base to testnet * chore: fix date of v0.12.5 in changelog * 0.12.5 --------- Co-authored-by: npty <[email protected]> Co-authored-by: Alan Soares <[email protected]> Co-authored-by: Jon Ator <[email protected]> Co-authored-by: Stephen Fluin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two things:
addNativeGasmethod should accept additional parameters to allow the invoker to specify what gas amount and gas multiple to useaddNativeGas, which callssubtractGasFee, should subtract the base fee if the transaction has already been confirmed. (as per necessary fixes for addNativeGas method #239)