-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement add gas function for sui #335
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrsirapop
reviewed
Nov 8, 2024
@nrsirapop I've published the new version to fix cors issue. npm i @axelar-network/[email protected] Could you please try updating to see if it's fixed? |
npty
commented
Nov 11, 2024
pjenviri
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://axelarnetwork.atlassian.net/browse/AXE-6365
This PR implements add gas function for sui. Also, the typescript version is bumped to the latest version (5.6.3)
Noted:
amount
is an optional params for now, if the user hasn't passed the amount, it is temporarily hardcoded as0.01
Sui. The default value will be updated after this pr is merged.Usage
Here's an usage example for node.js application.
For web application like axelarscan, you may want to use sui's dapps kit, so you can use this hook and pass the returned transaction into the
signAndExecuteTransaction
function.Pre-release Version
Blockers For Merging
devnet-amplifier
config with latest sui contract info (same as this one) deployed to s3. I've hardcoded it to point to the raw file in the github repo instead.