Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(its)!: add more checks for its hub routing #268

Merged
merged 2 commits into from
Aug 7, 2024
Merged

fix(its)!: add more checks for its hub routing #268

merged 2 commits into from
Aug 7, 2024

Conversation

milapsheth
Copy link
Member

@milapsheth milapsheth commented Aug 6, 2024 •
edited by jira bot
Loading

@milapsheth milapsheth requested a review from a team as a code owner August 6, 2024 20:24
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.52%. Comparing base (124db7e) to head (166c16b).

Files Patch % Lines
contracts/InterchainTokenService.sol 85.18% 0 Missing and 4 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
+ Coverage   95.67%   96.52%   +0.84%     
==========================================
  Files          19       19              
  Lines         601      604       +3     
  Branches      124      123       -1     
==========================================
+ Hits          575      583       +8     
+ Misses         11        5       -6     
- Partials       15       16       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ahramy
ahramy approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@ahramy ahramy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@milapsheth milapsheth merged commit 6e99005 into main Aug 7, 2024
5 checks passed
@milapsheth milapsheth deleted the fix/its-hub-source branch August 7, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahramy ahramy ahramy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milapsheth @codecov-commenter @ahramy