refactor!: implement AxelarExecutable and AxelarExecutableWithToken in ITS #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahramy
commented
Aug 21, 2024
ahramy
commented
Aug 21, 2024
ahramy
changed the title
milapsheth
reviewed
Sep 4, 2024
milapsheth
reviewed
Sep 6, 2024
milapsheth
reviewed
Sep 6, 2024
milapsheth
approved these changes
Sep 25, 2024
ahramy
changed the title
hydrobeam
reviewed
Oct 10, 2024
ahramy
changed the title
milapsheth
approved these changes
Oct 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
=======================================
Coverage 97.67% 97.67%
=======================================
Files 19 19
Lines 601 602 +1
Branches 126 126
=======================================
+ Hits 587 588 +1
Misses 5 5
Partials 9 9 ☔ View full report in Codecov by Sentry. |
milapsheth
requested changes
Oct 17, 2024
milapsheth
approved these changes
Oct 25, 2024
ahramy
deleted the
refactor/implement-axelar-gmp-executable-with-token
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXE-4660 : Inherit the simpler AxelarGMPExecutableWithToken abstract contract in ITS contract instead of re-implementing it. The original AxelarExecutable wasn’t including the commandId and it was including the full gateway interface that’s susceptible to changes.
AXE-5795