Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: addressed ackee's report #312

Merged
merged 16 commits into from
Jan 6, 2025
Prev Previous commit
Next Next commit
fixed a test and a test name
  • Loading branch information
Foivos committed Dec 20, 2024
commit 862eeb407266703ff1555ed8bd3601ce0106c9f3
2 changes: 1 addition & 1 deletion test/InterchainTokenFactory.js
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ describe('InterchainTokenFactory', () => {
await checkRoles(tokenManager, minter);
});

it('Should register a token if the mint amount is zero and minter is the zero address', async () => {
it('Should revert when trying to register a token if the mint amount is zero and minter is the zero address', async () => {
const salt = keccak256('0x123456');
tokenId = await tokenFactory.interchainTokenId(wallet.address, salt);

Expand Down
4 changes: 2 additions & 2 deletions test/InterchainTokenService.js
Original file line number Diff line number Diff line change
Expand Up @@ -909,13 +909,13 @@ describe('Interchain Token Service', () => {
);
});

it('Should revert on deploying a token manager with an empty token', async () => {
it('Should revert on deploying a token manager if token handler post deploy fails', async () => {
const params = defaultAbiCoder.encode(['bytes', 'address'], [wallet.address, AddressZero]);

await expectRevert(
(gasOptions) => service.deployTokenManager(salt, '', LOCK_UNLOCK, params, 0, gasOptions),
service,
'TokenManagerDeploymentFailed',
'PostDeployFailed',
);
});

Expand Down
Loading