Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
File: halo2-ecc/src/ecc/mod.rs
Added missing article "an":
// Old:
// is_started[idx] holds whether there is a 1 in bits with index at least (rounded_bitlen - idx)
// New:
// is_started[idx] holds whether there is a 1 in bits with an index at least (rounded_bitlen - idx)
Added missing article "an":
// Old:
// this all needs strict add_unequal since A can be non-randomly chosen by adversary
// New:
// this all needs strict add_unequal since A can be non-randomly chosen by an adversary
File: hashes/zkevm/src/sha256/README.md
// Old:
output
(2): the hash digest the SHA-256 algorithm on the input bytes// New:
output
(2): the hash digest of the SHA-256 algorithm on the input bytes// Old:
// New: