Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar and Clarity Improvements #276

Open
wants to merge 2 commits into
base: community-edition
Choose a base branch
from

Conversation

donatik27
Copy link

Changes

File: halo2-ecc/src/ecc/mod.rs

  1. Added missing article "an":
    // Old:
    // is_started[idx] holds whether there is a 1 in bits with index at least (rounded_bitlen - idx)
    // New:
    // is_started[idx] holds whether there is a 1 in bits with an index at least (rounded_bitlen - idx)

  2. Added missing article "an":
    // Old:
    // this all needs strict add_unequal since A can be non-randomly chosen by adversary
    // New:
    // this all needs strict add_unequal since A can be non-randomly chosen by an adversary

File: hashes/zkevm/src/sha256/README.md

  1. Added missing "of":
    // Old:
  • output (2): the hash digest the SHA-256 algorithm on the input bytes
    // New:
  • output (2): the hash digest of the SHA-256 algorithm on the input bytes
  1. Fixed adverb form:
    // Old:
  • We convenient store the relevant cells
    // New:
  • We conveniently store the relevant cells

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant