fix: AggregationDependencyIntent should include full accumulator_indices
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpwang
added a commit
that referenced
this pull request
Jan 18, 2024
- #37 Note on commit history: #37 was merged first into this branch at c7d7a8f, then some changes were made to `release-0.1.6-rc0`, so I rebased `release-0.1.6-rc0` onto this branch and force pushed. Utilities to generate dummy snarks to help with proving key generation of aggregation circuits: * #48 * #49 Merge after: - [x] v0.1.6 merged to main - [x] halo2-lib v0.4.1 merged to main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For greatest generality,
AggregationDependencyIntentshould include fullaccumulator_indicesand not just a booleanis_aggregation. Otherwise aggregation circuits that have accumulator indices elsewhere cannot be supported.