Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Release axoasset version 0.6.1 #75

Merged
merged 1 commit into from
Dec 19, 2023
Merged

chore: Release axoasset version 0.6.1 #75

merged 1 commit into from
Dec 19, 2023

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Dec 19, 2023

No description provided.

Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious: was this dynamically linking more than the one misty caught?

@Gankra Gankra marked this pull request as draft December 19, 2023 15:11
@Gankra
Copy link
Contributor Author

Gankra commented Dec 19, 2023

per discussion in discord, #74 isn't actually fixing a "change", we've been happily linking lzma forever, so delaying the release on further discussion (my current stance is that since the dynamic link is so reliable, static linking can only come with downsides).

@mistydemeo
Copy link
Contributor

per discussion in discord, #74 isn't actually fixing a "change", we've been happily linking lzma forever

It turns out this was only true on Intel: we were opportunistically linking it from the package manager, and because our Apple Silicon builds are on a runner without an Apple Silicon Homebrew, there wasn't a library for us to link against on Apple Silicon.

(my current stance is that since the dynamic link is so reliable, static linking can only come with downsides).

Since this is architecture-specific behaviour, and is also an artifact of our build environment, I think there is an upside here: predictability and intent. As well, since this liblzma comes from Homebrew, it means the Intel cargo-dist binary might not run for some of our users. If the user doesn't have Homebrew or doesn't have liblzma in a place the dynamic linker can find it, it won't run.

@Gankra Gankra marked this pull request as ready for review December 19, 2023 21:55
@Gankra Gankra merged commit a23d52e into main Dec 19, 2023
14 checks passed
@Gankra Gankra deleted the rel61 branch December 19, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants