-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have workflows run dist plan
on all known tags.
#1567
Conversation
914024d
to
7a3ed9e
Compare
7a3ed9e
to
e0f1b94
Compare
@@ -134,6 +134,8 @@ pub enum Commands { | |||
/// Report on the dynamic libraries used by the built artifacts. | |||
#[clap(disable_version_flag = true)] | |||
Linkage(LinkageArgs), | |||
/// List all version tags known by dist. | |||
ListTags(ListTagsArgs), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wonder if we shouldn't make this a tag command with the subcommand list, e.g. dist tag list
As discussed on Discord, currently setting this aside because of the complexity caused by this: cargo-dist/cargo-dist/templates/ci/github/release.yml.j2 Lines 143 to 149 in b487ee9
|
Hi @duckinator! Just to confirm, it sounds like from the last comment that the plan is to not resolve the We're currently blocked on this for the next release of Hipcheck, and if that's the case we'll route around it. Of course we have the benefit of being able to fork and kludge our own thing in the meantime until this is resolved upstream. |
@alilleybrinker unfortunately the scope on this grew pretty significantly because of how much it interacts with other parts of the codebase. I ran into a thing blocking me from making any progress at all today, so I was asked to switch to a task I can actually make progress on. I'm not sure what the plan for this task is after today; I'd need to discuss that with @ashleygwilliams. If you do try your own temporary fork and would like my input on something, I tend to be on the axodotdev Discord 10am-4pm eastern (7am-1pm pacific) on weekdays. |
No problem! I'm talking with Ashley as well and will see what we can do. Thanks so much for the help so far on this, including the draft changes here! Totally understand about this hitting some complex parts of the system. |
We went with #1579 instead. |
General idea:
dist plan --output-format=json --tag=${TAG} > plan-dist-manifest-${TAG}.json
for each oneReplaces #1560.