Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have workflows run dist plan on all known tags. #1567

Closed
wants to merge 1 commit into from
Closed

Conversation

duckinator
Copy link
Contributor

@duckinator duckinator commented Nov 19, 2024

General idea:

  • add a command (or flag for dist plan) that prints a JSON representation of all possible tags
  • in the generated workflow, use that new command to determine what tags there are, and run dist plan --output-format=json --tag=${TAG} > plan-dist-manifest-${TAG}.json for each one

Replaces #1560.

@@ -134,6 +134,8 @@ pub enum Commands {
/// Report on the dynamic libraries used by the built artifacts.
#[clap(disable_version_flag = true)]
Linkage(LinkageArgs),
/// List all version tags known by dist.
ListTags(ListTagsArgs),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if we shouldn't make this a tag command with the subcommand list, e.g. dist tag list

@duckinator
Copy link
Contributor Author

As discussed on Discord, currently setting this aside because of the complexity caused by this:

dist
{{%- if dispatch_releases %}} ${{ (inputs.tag && inputs.tag != 'dry-run' && format('host --steps=create --tag={0}', inputs.tag))
{{%- elif release_branch %}} ${{ (!github.event.pull_request && 'host --steps=create --tag=timestamp --force-tag')
{{%- else %}} ${{ (!github.event.pull_request && format('host --steps=create --tag={0}', github.ref_name))
{{%- endif %}}
{{%- if "axodotdev" in hosting_providers %}} || (env.AXO_RELEASES_TOKEN && 'host --steps=check') {{%- endif %}}
{{{- " || 'plan' }} --output-format=json > plan-dist-manifest.json" | safe }}}

@alilleybrinker
Copy link
Contributor

Hi @duckinator! Just to confirm, it sounds like from the last comment that the plan is to not resolve the dist plan issue with inconsistent tags in the immediate term. Do I have that right?

We're currently blocked on this for the next release of Hipcheck, and if that's the case we'll route around it. Of course we have the benefit of being able to fork and kludge our own thing in the meantime until this is resolved upstream.

@duckinator
Copy link
Contributor Author

@alilleybrinker unfortunately the scope on this grew pretty significantly because of how much it interacts with other parts of the codebase. I ran into a thing blocking me from making any progress at all today, so I was asked to switch to a task I can actually make progress on. I'm not sure what the plan for this task is after today; I'd need to discuss that with @ashleygwilliams.

If you do try your own temporary fork and would like my input on something, I tend to be on the axodotdev Discord 10am-4pm eastern (7am-1pm pacific) on weekdays.

@alilleybrinker
Copy link
Contributor

No problem! I'm talking with Ashley as well and will see what we can do. Thanks so much for the help so far on this, including the draft changes here! Totally understand about this hitting some complex parts of the system.

kekonn added a commit to kekonn/fercord that referenced this pull request Nov 21, 2024
@duckinator
Copy link
Contributor Author

We went with #1579 instead.

@duckinator duckinator closed this Dec 2, 2024
@duckinator duckinator deleted the multiplan branch December 6, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants