Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) add v1 "dist init" #1737

Closed
wants to merge 2 commits into from

[BROKEN, WIP] more work on v1 do_init()

0317e45
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Closed

(WIP) add v1 "dist init" #1737

[BROKEN, WIP] more work on v1 do_init()
0317e45
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy failed Feb 11, 2025 in 0s

clippy

26 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 26
Warning 0
Note 0
Help 0

Versions

  • rustc 1.79.0 (129f3b996 2024-06-10)
  • cargo 1.79.0 (ffa9cf99a 2024-06-03)
  • clippy 0.1.79 (129f3b9 2024-06-10)

Annotations

Check failure on line 54 in cargo-dist/src/init/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

error: variable does not need to be mutable
  --> cargo-dist/src/init/mod.rs:54:9
   |
54 |     let mut did_add_profile = false;
   |         ----^^^^^^^^^^^^^^^
   |         |
   |         help: remove this `mut`

Check failure on line 56 in cargo-dist/src/init/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `workspace`

error: unused variable: `workspace`
  --> cargo-dist/src/init/mod.rs:56:13
   |
56 |         let workspace = workspaces.workspace(workspace_idx);
   |             ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_workspace`

Check failure on line 23 in cargo-dist/src/init/interactive.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

error: variable does not need to be mutable
  --> cargo-dist/src/init/interactive.rs:23:9
   |
23 |     let mut meta = if has_config {
   |         ----^^^^
   |         |
   |         help: remove this `mut`
   |
   = note: `-D unused-mut` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_mut)]`

Check failure on line 17 in cargo-dist/src/init/interactive.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `args`

error: unused variable: `args`
  --> cargo-dist/src/init/interactive.rs:17:5
   |
17 |     args: &InitArgs,
   |     ^^^^ help: if this is intentional, prefix it with an underscore: `_args`

Check failure on line 16 in cargo-dist/src/init/interactive.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `cfg`

error: unused variable: `cfg`
  --> cargo-dist/src/init/interactive.rs:16:5
   |
16 |     cfg: &Config,
   |     ^^^ help: if this is intentional, prefix it with an underscore: `_cfg`

Check failure on line 899 in cargo-dist/src/init/apply_dist.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `publishers`

error: unused variable: `publishers`
   --> cargo-dist/src/init/apply_dist.rs:899:51
    |
899 | fn apply_publishers(table: &mut toml_edit::Table, publishers: &Option<PublisherLayer>) {
    |                                                   ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_publishers`

Check failure on line 591 in cargo-dist/src/init/apply_dist.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `hosts`

error: unused variable: `hosts`
   --> cargo-dist/src/init/apply_dist.rs:591:46
    |
591 | fn apply_hosts(table: &mut toml_edit::Table, hosts: &Option<HostLayer>) {
    |                                              ^^^^^ help: if this is intentional, prefix it with an underscore: `_hosts`

Check failure on line 574 in cargo-dist/src/init/apply_dist.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `ci`

error: unused variable: `ci`
   --> cargo-dist/src/init/apply_dist.rs:574:43
    |
574 | fn apply_ci(table: &mut toml_edit::Table, ci: &Option<CiLayer>) {
    |                                           ^^ help: if this is intentional, prefix it with an underscore: `_ci`

Check failure on line 563 in cargo-dist/src/init/apply_dist.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `builds_table`

error: unused variable: `builds_table`
   --> cargo-dist/src/init/apply_dist.rs:563:5
    |
563 |     builds_table: &mut toml_edit::Table,
    |     ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_builds_table`

Check failure on line 566 in cargo-dist/src/init/apply_dist.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `system_dependencies`

error: unused variable: `system_dependencies`
   --> cargo-dist/src/init/apply_dist.rs:566:14
    |
566 |     let Some(system_dependencies) = system_dependencies else {
    |              ^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_system_dependencies`
    |
    = note: `-D unused-variables` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(unused_variables)]`

Check failure on line 54 in cargo-dist/src/init/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

error: variable does not need to be mutable
  --> cargo-dist/src/init/mod.rs:54:9
   |
54 |     let mut did_add_profile = false;
   |         ----^^^^^^^^^^^^^^^
   |         |
   |         help: remove this `mut`

Check failure on line 56 in cargo-dist/src/init/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `workspace`

error: unused variable: `workspace`
  --> cargo-dist/src/init/mod.rs:56:13
   |
56 |         let workspace = workspaces.workspace(workspace_idx);
   |             ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_workspace`

Check failure on line 23 in cargo-dist/src/init/interactive.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

error: variable does not need to be mutable
  --> cargo-dist/src/init/interactive.rs:23:9
   |
23 |     let mut meta = if has_config {
   |         ----^^^^
   |         |
   |         help: remove this `mut`
   |
   = note: `-D unused-mut` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_mut)]`

Check failure on line 17 in cargo-dist/src/init/interactive.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `args`

error: unused variable: `args`
  --> cargo-dist/src/init/interactive.rs:17:5
   |
17 |     args: &InitArgs,
   |     ^^^^ help: if this is intentional, prefix it with an underscore: `_args`

Check failure on line 16 in cargo-dist/src/init/interactive.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `cfg`

error: unused variable: `cfg`
  --> cargo-dist/src/init/interactive.rs:16:5
   |
16 |     cfg: &Config,
   |     ^^^ help: if this is intentional, prefix it with an underscore: `_cfg`

Check failure on line 899 in cargo-dist/src/init/apply_dist.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `publishers`

error: unused variable: `publishers`
   --> cargo-dist/src/init/apply_dist.rs:899:51
    |
899 | fn apply_publishers(table: &mut toml_edit::Table, publishers: &Option<PublisherLayer>) {
    |                                                   ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_publishers`

Check failure on line 591 in cargo-dist/src/init/apply_dist.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `hosts`

error: unused variable: `hosts`
   --> cargo-dist/src/init/apply_dist.rs:591:46
    |
591 | fn apply_hosts(table: &mut toml_edit::Table, hosts: &Option<HostLayer>) {
    |                                              ^^^^^ help: if this is intentional, prefix it with an underscore: `_hosts`

Check failure on line 574 in cargo-dist/src/init/apply_dist.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `ci`

error: unused variable: `ci`
   --> cargo-dist/src/init/apply_dist.rs:574:43
    |
574 | fn apply_ci(table: &mut toml_edit::Table, ci: &Option<CiLayer>) {
    |                                           ^^ help: if this is intentional, prefix it with an underscore: `_ci`

Check failure on line 563 in cargo-dist/src/init/apply_dist.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `builds_table`

error: unused variable: `builds_table`
   --> cargo-dist/src/init/apply_dist.rs:563:5
    |
563 |     builds_table: &mut toml_edit::Table,
    |     ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_builds_table`

Check failure on line 566 in cargo-dist/src/init/apply_dist.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `system_dependencies`

error: unused variable: `system_dependencies`
   --> cargo-dist/src/init/apply_dist.rs:566:14
    |
566 |     let Some(system_dependencies) = system_dependencies else {
    |              ^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_system_dependencies`
    |
    = note: `-D unused-variables` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(unused_variables)]`

Check failure on line 11 in cargo-dist/src/init/interactive.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `super::console_helpers`

error: unused import: `super::console_helpers`
  --> cargo-dist/src/init/interactive.rs:11:5
   |
11 | use super::console_helpers;
   |     ^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 6 in cargo-dist/src/init/interactive.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `DistError`

error: unused import: `DistError`
 --> cargo-dist/src/init/interactive.rs:6:21
  |
6 | use crate::errors::{DistError, DistResult};
  |                     ^^^^^^^^^
  |
  = note: `-D unused-imports` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(unused_imports)]`

Check failure on line 11 in cargo-dist/src/init/interactive.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `super::console_helpers`

error: unused import: `super::console_helpers`
  --> cargo-dist/src/init/interactive.rs:11:5
   |
11 | use super::console_helpers;
   |     ^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 6 in cargo-dist/src/init/interactive.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `DistError`

error: unused import: `DistError`
 --> cargo-dist/src/init/interactive.rs:6:21
  |
6 | use crate::errors::{DistError, DistResult};
  |                     ^^^^^^^^^
  |
  = note: `-D unused-imports` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(unused_imports)]`

Check failure on line 107 in cargo-dist/src/init/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

cannot find value `check` in this scope

error[E0425]: cannot find value `check` in this scope
   --> cargo-dist/src/init/mod.rs:107:23
    |
107 |                     "{check} added [package.metadata.dist] to {}'s Cargo.toml",
    |                       ^^^^^ not found in this scope