update typed-builder and improve ci #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdJoPaTo
reviewed
Sep 18, 2023
.github/workflows/rust.yml
Outdated
| @@ -3,6 +3,7 @@ name: Test and Build Rust | |||
| on: | |||
| push: | |||
| pull_request: | |||
| types: [opened, reopened] | |||
There was a problem hiding this comment.
Shouldnt it also run when there is something new pushed? I would remove the filter here as its also simpler then. Or do I overlook something?
There was a problem hiding this comment.
it runs on every push. the problem is on every push before my changes every ci step was running twice
There was a problem hiding this comment.
pull_request merges with the target branch and runs on pull request activity like new pushes to the pull request while push runs only for branches in this repo. Pull Requests from other people are not on branches in this repo and are therefore not included in push.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.