Use i64 for ChatShared::chat_id
#162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdJoPaTo
reviewed
Apr 23, 2024
| @@ -1578,7 +1578,7 @@ pub struct UsersShared { | |||
| pub struct ChatShared { | |||
| pub request_id: i32, | |||
|
|
|||
| pub chat_id: u64, | |||
| pub chat_id: i64, | |||
There was a problem hiding this comment.
frankenstein/src/api_params.rs
Line 136 in cc469d6
Suggested change
| pub chat_id: i64, | |
| pub chat_id: ChatId, |
There was a problem hiding this comment.
It seems like this enum is intended to be used solely in requests (as the file name suggests: API params). Is it supposed to be used to parse response data too? All other received chat IDs are parsed as i64 and u64
There was a problem hiding this comment.
Good point. Then I guess i64 is the way to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chat IDs can be negative, which causes response parsing to fail when the user selects a supergroup.