refactor!: flatten the module structure #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traits and clients are now on the top level. Error and response structs are moved to their dedicated modules. Also, a bunch of doc comments are added so the docs.rs/frankenstein entry has somewhat better docs BREAKING CHANGE: old modules for them are gone and import is only possible from the top level. Responses moved from frankenstein::api_traits::MethodResponse to frankenstein::response::MethodResponse (and are also reexported on top level).
EdJoPaTo
commented
Sep 12, 2024
| pub use ureq; | ||
| pub use self::client_ureq::*; | ||
| pub use self::error::Error; | ||
| pub use self::objects::*; |
There was a problem hiding this comment.
pub use self::… or pub use crate::…?
ayrat555
approved these changes
Sep 13, 2024
|
@EdJoPaTo can you please fix conflicts? |
Conflicts: src/lib.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traits and clients are now on the top level. Error and response structs are moved to their dedicated modules. Also, a bunch of doc comments are added so the https://docs.rs/frankenstein entry has somewhat better docs.
This is a part of the changes of #203
BREAKING CHANGE: old modules for them are gone and import is only possible from the top level now. Responses moved from
frankenstein::api_traits::MethodResponsetofrankenstein::response::MethodResponse(and are also re-exported on top level).