-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(cargo): update bon requirement from 2.2.0 to 3.0.2 #231
Conversation
Updates the requirements on [bon](https://github.com/elastio/bon) to permit the latest version. - [Release notes](https://github.com/elastio/bon/releases) - [Changelog](https://github.com/elastio/bon/blob/master/release-plz.toml) - [Commits](elastio/bon@v2.2.0...v3.0.2) --- updated-dependencies: - dependency-name: bon dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Interestingly, a warning from serde appears 😳, I'll try to take a look at it |
Ah, I think there are repetitions in This is related to serde-rs/serde#2308 |
yeah, that's what #230 is about ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation is way cleaner, but I still think having all the builders listed next to the structs is still doubling a way too long list which is a bit annoying.
The minimum version can be lowered, otherwise this is a welcome improvement.
@@ -73,7 +73,7 @@ name = "api_trait_implementation" | |||
required-features = ["telegram-trait"] | |||
|
|||
[dependencies] | |||
bon = "2.2.0" | |||
bon = "3.0.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess 3.0.0 would be the minimum. The fix included with 3.0.1 is not relevant in frankenstein (currently?) and 3.0.2 fixes a lint warning on nightly only but still works fine without.
bon = "3.0.2" | |
bon = "3.0.0" |
Do you think it makes sense to hide builders from the docs? If so, there could be an option in Smth like: pub mod builders {
pub use super::types::{FooBuilder, /* ... */};
}
pub use types::{Foo, /* ... */};
mod types {
#[derive(Builder)]
pub struct Foo { /**/ }
// ...
} |
Unfortunately Your idea might be neat to have automatically: having all builder structs in a builder sub-module. Not sure how that might explode with bon in doc comments and so on. Maybe this discussion should be moved over to some bon issue? |
I've created elastio/bon#214. I proposed a wokraround there with a declarative macro to achieve this. Do you think that would be enough to solve this problem for this case? |
Superseded by #232. |
Updates the requirements on bon to permit the latest version.
Release notes
Sourced from bon's releases.
Commits
d8b589f
chore: release v3.0.2 (#213)8e7f0d1
Fixunexpected_cfg
lint coming from#[cfg(rust_analyzer)]
(#212)be3e2b2
AddFUNDING.yml
with patreon and ko-fi (#210)ac2f43c
chore: release v3.0.1 (#209)c985900
Fix handling of lifetimes not used in fn param types (#208)dad40c7
Fix broken links and some grammar (#205)066f9da
Fix links to log images (#204)fa92e10
Remove misleading sentence in optional generic members pattern (#202)f3d8ddb
Add blog post link to the changelog (#201)a0c2ec0
Add release announcement to the readme (#200)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)