Bot API 8.0 - Gifts #237
Bot API 8.0 - Gifts #237
Conversation
| #[serde(tag = "type", rename_all = "snake_case")] | ||
| pub enum TransactionPartner { | ||
| User(TransactionPartnerUser), | ||
| User(Box<TransactionPartnerUser>), |
There was a problem hiding this comment.
Is there a reason to use a Box instead of an owned value ?
There was a problem hiding this comment.
there is a warning from clippy that one of the variants is too large
| @@ -2238,23 +2252,24 @@ pub struct RevenueWithdrawalStateSucceeded { | |||
| #[derive(Eq)] | |||
| pub struct RevenueWithdrawalStateFailed {} | |||
|
|
|||
| #[derive(Clone, Debug, Serialize, Deserialize, PartialEq, Eq)] | |||
There was a problem hiding this comment.
Why is it not using the api_struct macro?
There was a problem hiding this comment.
it's enum. this macro is not applicable for enums
| pub gift_id: String, | ||
| pub text: Option<String>, | ||
| pub text_parse_mode: Option<ParseMode>, | ||
| pub text_entities: Option<Vec<MessageEntity>>, |
There was a problem hiding this comment.
is an empty Vec simpler than None?
There was a problem hiding this comment.
I think it is better to be loyal to the Telegram API spec.
https://core.telegram.org/bots/api#sendgift
According to the spec this parameter is optional.
If we use empty vec may be simpler but it will be telling the library user that this parameter is required which is not true.
There was a problem hiding this comment.
question is will it be able to decode as empty list if the field is not provided. for now I will merge as Option. but @EdJoPaTo you're free to submit pr changng that
* Bot API 8.0 - Media Sharing and File Downloads * Bot API 8.0 - Gifts (#237)
No description provided.