feat!: name clients Bot to differentiate from TelegramApi #253
+104
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With having both named `Api` and `TelegramApi` its not as easy to understand what is what. One describes the interface (`TelegramApi`) and one is used to actually interact with the Bot (`Bot`). As the update to 0.39 will require users to explictly specify the new features they will know the name of the http client they want anyway.
ayrat555
reviewed
Feb 1, 2025
ayrat555
reviewed
Feb 1, 2025
Conflicts: examples/custom_client.rs src/client_ureq.rs
For example when looking at an old crate / readme version the badges show the current version which doesnt really fit the content well. Also, the build information is most of the time pointless to know when looking at the readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With having both named
ApiandTelegramApiit's not as easy to understand what is what. One describes the interface (TelegramApi) and one is used to actually interact with the Bot (Bot).As the update to 0.39 will require users to explicitly specify the new features they will know the name of the HTTP client they want anyway.