fix: move @typescript-eslint/types to dependencies #150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved
@typescript-eslint/types
todependencies
, updatingpackage.json
andpnpm-lock.yaml
.Additional context
@typescript-eslint/types
is a ghost dependency (also known as a phantom dependency).The module utils/is-member-optional.ts imports
@typescript-eslint/types
as a runtime dependency (for using theAST_NODE_TYPES
object), but@typescript-eslint/types
is listed indevDependencies
instead ofdependencies
.Since it is not listed as a runtime dependency,
eslint-plugin-perfectionist
cannot be used in projects that are configured to catch ghost dependencies.Running
eslint@8
witheslint-plugin-perfectionist
on a project with Yarn 4.x and Plug'n'Play generates this output:What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).