Remove reconfigureOnUpdate prop. Reconfigure whenever stripeKey changes. #111
Conversation
| componentDidUpdate() { | ||
| if (!scriptLoading) { | ||
| componentDidUpdate(prevProps) { | ||
| if (!scriptLoading && this.props.stripeKey !== prevProps.stripeKey) { |
There was a problem hiding this comment.
This is the wrong comparison to make. The stripeHandler is a static member of ReactStripeCheckout, so it may have been set by a completely different instance of the component.
There was a problem hiding this comment.
I see what you are saying about multiple instances of the component.
All I'm doing here is replacing the reconfigureOnUpdate option with a prop check that checks for the only prop that matters for reconfiguring.
As currently written it doesn't appear that this component will work with multiple instances of the component each with their own stripe key and this PR isn't attempting to fix that.
There was a problem hiding this comment.
Agreed. That's why I put together #116 based on your work, which does allow for proper support for multiple instances with different Stripe keys.
This removes the need for
reconfigureOnUpdate. It didn't work right. It would cause stripe to update too often and wasn't necessary. Now we just watch forstripeKeyto change. I've been using this code in production for a few months.resolve #103