-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config checkbox to show/hide redirect URLs on Homepage #307
base: unstable
Are you sure you want to change the base?
Conversation
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, add yourself to the .clabot file as contributor, as a way of signing the CLA. |
Thanks for the contribution! |
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, add yourself to the .clabot file as contributor, as a way of signing the CLA. |
I get what you're saying, then by this logic, changing the URL mode automatically decides the base value for HideFromDashboard, so I've implemented a simple onChange method for when a user changes the URL mode. What do you say? |
Yes that looks better thanks! Could you remove the condition with the skip altogether? I dont think it will be required anymore since the value is always false |
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, add yourself to the .clabot file as contributor, as a way of signing the CLA. |
Done, is this what you meant? |
This gives users more personalization for what is shown on the home page :)