Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework IsLocalIP using standard library functions #358

Merged
merged 2 commits into from
Dec 15, 2024

Conversation

r41d
Copy link
Contributor

@r41d r41d commented Nov 28, 2024

  • don't hardcode IPs but rather use the standard library for checking loopback and private networks
  • one of the old checks with strings.HasPrefix(ip, "172.") was too broad because the private range is 172.16/12 and not 172/8
  • addtional private networks are added

Copy link

cla-bot bot commented Nov 28, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, add yourself to the .clabot file as contributor, as a way of signing the CLA.

Copy link

cla-bot bot commented Nov 28, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, add yourself to the .clabot file as contributor, as a way of signing the CLA.

@r41d
Copy link
Contributor Author

r41d commented Nov 28, 2024

Hmm, the bot seems to fetch the .clabot file from the original repo and not my branch 🤔

@r41d
Copy link
Contributor Author

r41d commented Dec 5, 2024

Any feedback or something that could be done better?

@azukaar azukaar merged commit bbaa951 into azukaar:master Dec 15, 2024
1 check failed
azukaar added a commit that referenced this pull request Dec 15, 2024
azukaar added a commit that referenced this pull request Dec 15, 2024
@azukaar
Copy link
Owner

azukaar commented Dec 15, 2024

Hey Thanks for the PR, upon merging it I realized that you created a PR against Master instead of unstable, could you redirect it?
dont worry about cla bot he is a lilttle... slow :p

@r41d
Copy link
Contributor Author

r41d commented Dec 16, 2024

Hey Thanks for the PR, upon merging it I realized that you created a PR against Master instead of unstable, could you redirect it? dont worry about cla bot he is a lilttle... slow :p

Done :)
#364

@azukaar
Copy link
Owner

azukaar commented Dec 16, 2024

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants