-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework IsLocalIP using standard library functions #358
Conversation
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, add yourself to the .clabot file as contributor, as a way of signing the CLA. |
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, add yourself to the .clabot file as contributor, as a way of signing the CLA. |
Hmm, the bot seems to fetch the |
Any feedback or something that could be done better? |
Hey Thanks for the PR, upon merging it I realized that you created a PR against Master instead of unstable, could you redirect it? |
Done :) |
Thanks!! |
strings.HasPrefix(ip, "172.")
was too broad because the private range is172.16/12
and not172/8