fix(grpcgen): remove ambiguous message about missing --file when using compilation database #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g compilation database When using a compilation database, a message stating that the "File was missing" was printed, leading to think something was wrong whereas it's expected behavior. Also: - perform option validation to keep --file and --database_dir mutually exclusive - handle parsing error (used to be ignored for --database_dir path)
Options --file and --database_dir are actually not mutually exclusive. When parsing a file, the compilation database is used to resolve symbols when passed to initOptions(). Change "File is missing" by a message that sounds less as an error.
jim-bcom
force-pushed
the
fix/grpcgen-cli-file-vs-db
branch
from
f7995cc to
bc064b5
Compare
|
Reverted the check for mutual exclusion of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a compilation database, a message stating that the "File was missing" was printed, leading to think something was wrong whereas it's expected behavior.
Also: