Merge pull request #59 from ba-st/transient_gs64

Make LaunchpadApplication transient using Tonel options

rowan/components/scripts/deploymentPostload.st

@@ -1,38 +1 @@
-"Recompile LaunchpadApplication and CurrentlyRunningLaunchpadApplication with dbTransient option
- so that instances are not persistent because they store session-dependent information only"
-
-| removeNonTransientVersionsOf |
-removeNonTransientVersionsOf := [:class |
-    | nonTransientVersions |
-    nonTransientVersions := class classHistory reject: [:classVersion | classVersion instancesDbTransient].
-    nonTransientVersions do: [:classVersion | class classHistory removeVersion: classVersion]].
-
-LaunchpadApplication instancesDbTransient
-    ifFalse: [
-        Object subclass: 'LaunchpadApplication'
-        	instVarNames: LaunchpadApplication instVarNames
-        	classVars: LaunchpadApplication classVarNames
-        	classInstVars: LaunchpadApplication class instVarNames
-        	poolDictionaries: LaunchpadApplication _poolDictionaries
-        	inDictionary: Launchpad
-        	options: #( dbTransient ).
-        (OrderedCollection new
-            add: LaunchpadApplication;
-            addAll: LaunchpadApplication allSubclasses;
-            yourself)
-                do: [:applicationClass | removeNonTransientVersionsOf value: applicationClass].
-    ].
-
-CurrentlyRunningLaunchpadApplication instancesDbTransient
-    ifFalse: [
-        Object subclass: 'CurrentlyRunningLaunchpadApplication'
-        	instVarNames: CurrentlyRunningLaunchpadApplication instVarNames
-        	classVars: CurrentlyRunningLaunchpadApplication classVarNames
-        	classInstVars: CurrentlyRunningLaunchpadApplication class instVarNames
-        	poolDictionaries: CurrentlyRunningLaunchpadApplication _poolDictionaries
-        	inDictionary: Launchpad
-        	options: #( dbTransient ).
-        removeNonTransientVersionsOf value: CurrentlyRunningLaunchpadApplication.
-    ].
-
 CurrentlyRunningLaunchpadApplication initializeUniqueInstance.

source/Launchpad-Applications/CurrentlyRunningLaunchpadApplication.class.st

@@ -7,6 +7,9 @@ Class {
 	#classVars : [
 		'uniqueInstance'
 	],
+	#gs_options : [
+		'dbTransient'
+	],
 	#category : 'Launchpad-Applications',
 	#package : 'Launchpad-Applications'
 }

source/Launchpad-Applications/LaunchpadApplication.class.st

@@ -7,6 +7,9 @@ Class {
 		'mode',
 		'commandServer'
 	],
+	#gs_options : [
+		'dbTransient'
+	],
 	#category : 'Launchpad-Applications',
 	#package : 'Launchpad-Applications'
 }

source/Launchpad-GS64-Extensions-Tests/CommandLineArgumentsTest.class.st

@@ -1,6 +1,3 @@
-"
-That class tests the API given by AbstractUserInput. Since that class is obviously abstract, it can't be instantiated, the tests are running on CommandLine (which inherits from AbstractUserInput)
-"
 Class {
 	#name : #CommandLineArgumentsTest,
 	#superclass : #TestCase,

source/Launchpad-GS64-Extensions-Tests/LaunchpadApplicationTransientTest.class.st

@@ -0,0 +1,27 @@
+Class {
+	#name : #LaunchpadApplicationTransientTest,
+	#superclass : #TestCase,
+	#instVars : [	],
+	#category : #'Launchpad-GS64-Extensions-Tests'
+}
+
+{ #category : #tests }
+LaunchpadApplicationTransientTest >> testAccessingRunningApplication [
+	| application |
+
+	application := LaunchpadBrokenApplication
+		               runningIn: DebuggingApplicationMode new
+		               configuredBy: NullConfigurationProvider new
+		               controlledBy: NullCommandServer new.
+
+	LaunchpadApplication setAsCurrentlyRunning: application.
+	System abortTransaction.
+	self assert: LaunchpadApplication currentlyRunning equals: application
+]
+
+{ #category : #running }
+LaunchpadApplicationTransientTest >> tearDown [
+
+	CurrentlyRunningLaunchpadApplication new resetCurrentlyRunning.
+	super tearDown
+]