Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Connection Header detection #1

Open
baalexander opened this issue Oct 4, 2011 · 0 comments
Open

Optimize Connection Header detection #1

baalexander opened this issue Oct 4, 2011 · 0 comments

Comments

@baalexander
Copy link
Owner

Using TCPROS, a Connection Header can be sent as part of the message buffer or, when using repeat messages, as its own buffer.

To check if the buffer is a connection header or message, the getMessageFromBuffer in tcpros.js converts the buffer to a String and checks for required properties sent by the publisher, like type. This is inefficient and needs a better way to detect if a connection header buffer. This could happen in subscriber.js as state isn't really assumed in tcpros.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant