-
Notifications
You must be signed in to change notification settings - Fork 60
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[CNSMR-3203] Add task review guidelines (#289)
* [CNSMR-3203] Add task review guidelines
- Loading branch information
Showing
1 changed file
with
62 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
|
|
||
| # Technical test reviewer guidelines | ||
|
|
||
| This document describes the guidelines for reviewing technical task assignments that candidates work on during the recruitment process. | ||
| Every question is attributed with **S/M/J** or a combination of those, defining what level it relates to. | ||
|
|
||
| - **S** (expected of a senior-level task) | ||
| - **M** (expected of a mid-level task) | ||
| - **J** (expected of a junior-level task) | ||
|
|
||
| > Note: | ||
| What we mean by `some` is that the requirement does not need to be completely satisfied. For example, an ideal senior level task should have all parts of the app designed for testability, but for a mid level test, we can consider if they exhibit this in a few parts. | ||
|
|
||
| ## General: | ||
|
|
||
| ### Basics | ||
| - Does it have clear instructions on how to run the project? (SMJ) | ||
| - Are there any compile time issues? (SMJ) | ||
| - Does it meet functional requirements? (SMJ) | ||
| - Are there any run time issues? (SM) | ||
| - Does it have descriptive README? (SM) | ||
|
|
||
| ### Good practices | ||
|
|
||
| - Is it testable? (S, some for M) | ||
| - Does it conform to the SOLID principles? (S, some for M) | ||
| - Does it use dependency injection? (S, some for M) | ||
| - Does it use descriptive naming? (SM) | ||
| - Is the code clean? (no dead code) (SM) | ||
| - Does it use encapsulation? (SM) | ||
| - Are there any warnings in the codebase? (SM) | ||
| - Are modules loosely coupled? (S) | ||
| - Is it performing operations on the right threads? (SM) | ||
| - Does it utilize reference and value semantics? (S) | ||
| - Does it use higher order functions? (bonus point) | ||
| - Is it modularized? (bonus point) | ||
|
|
||
| ## Architecture: | ||
|
|
||
| ### Networking | ||
| - Does it use `Codable`? (SMJ) | ||
| - Is it well abstracted? (S, some for M) | ||
| - Is it open for extensions? (like authorization, different routes and HTTP methods) (SM) | ||
| - Are errors propagated? (SM) | ||
| - Are requests cancelable? (S) | ||
|
|
||
| ### Persistence | ||
| - Is it well abstracted? (it does not leak implementation details to other layers) (S) | ||
|
|
||
| ### UI-Business logic | ||
| - Does `UIViewController` has only its clear responsibilities? (SM, some for J) | ||
| - Is there an abstraction of `UITableViewDataSource`/`UICollectionViewDataSource` (SM) | ||
| - Is navigation from one module to another not tightly coupled? (SM) | ||
| - Is there a data access layer in between (Persistence & Networking) and ViewModel/Presenter/ViewController? (S) | ||
| - Does it use unidirectional data flow? (bonus point) | ||
| - Is business logic state management done within UI state/actions? (bonus point) | ||
|
|
||
| ### UI | ||
| - Is the Auto Layout used? (SMJ) | ||
| - If Auto Layout is done in InterfaceBuilder, are constraints correct and not ambiguous? (SM) | ||
| - If Auto Layout is done in code, is it readable? (S) | ||
| - Are there any Auto Layout warnings in the console? (S) |