Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider having functionality separate into multiple contracts #11

Closed
maurolacy opened this issue Jul 31, 2024 · 1 comment
Closed

Consider having functionality separate into multiple contracts #11

maurolacy opened this issue Jul 31, 2024 · 1 comment

Comments

@maurolacy
Copy link
Collaborator

@maurolacy cloned issue babylonchain/babylon-contract#131 on 2024-06-05:

Related to #130.

btc-staking is growing big, and is in fact containing functionality related to finality signatures, and the finality providers set.

Consider introducing a new finality contract to handle finality votes, power, and the voting round. The power that comes frombtc-staking can be read through a raw query for performance.

See the poe-contracts (https://www.github.com/confio/poe-contracts) design / structure for reference / ideas.

Also, the voting round and the finality validator set, though related to finality, could be perhaps better be in its own fpset contract. Again, poe-contracts provides a reference for this.
@SebastianElvis
Copy link
Member

Subsumed by #52 and #53

@SebastianElvis SebastianElvis closed this as not planned Won't fix, can't repro, duplicate, stale Sep 4, 2024
This was referenced Sep 16, 2024
Merged
Merged
maurolacy added a commit that referenced this issue Sep 17, 2024
@maurolacy
R/index btc height (#64)
74c5c0b 
Remove BTC height indexing refactor.

Part of #11, having separate `btc-staking` and (a new)
`babylon-finality` contracts.
maurolacy added a commit that referenced this issue Sep 25, 2024
@maurolacy
R/finality contract (#65)
70b6af6 
Part of #11. Closes #52.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SebastianElvis @maurolacy