F/rewards claiming babylon #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurolacy
force-pushed
the
f/rewards-claiming-babylon
branch
from
4ee4b9a to
fbd3b31
Compare
added 19 commits
February 5, 2025 10:26
Depends on ICS-20 transfer info being set
maurolacy
force-pushed
the
f/rewards-claiming-babylon
branch
from
fbd3b31 to
2ccaebb
Compare
|
The relevant sections of the ADR are now updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewards withdrawal to a Babylon address. Depending on the ICS-020 channel information being set or not during contract instantiation.
#102 follow-up / complement. Tracking issue: https://github.com/babylonlabs-io/pm/issues/114.
TODO:
Test rewards withdrawal to a Babylon address(to be done as part of e2e tests).