-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rm auto register 2 #89
Conversation
From what I see the submodule somehow points to the |
Created a small commit to fix this. Btw, how about we use git clone to get the babylon repo, and then generate rust proto files? The submodule seems to create a lot of troubles |
Hmm, I like the submodule approach better. It requires some administration though. Here are the steps that I know and use:
|
I've now committed a change based in the sequence above. The trick here is always committing the submodule's branch / commit changes into the main repo before running |
Now, after changing / updating the proto files, the error[E0609]: no field `delegator_unbonding_info` on type `babylon_proto::babylon::btcstaking::v1::BtcUndelegationInfo`
--> packages/apis/src/btc_staking_api.rs:246:14
|
246 | .delegator_unbonding_info
| ^^^^^^^^^^^^^^^^^^^^^^^^ unknown field
|
help: a field with a similar name exists
|
246 | .delegator_unbonding_sig
| ~~~~~~~~~~~~~~~~~~~~~~~ Can you take a look? 🙏🏼 |
Hmm, I think I know what's happening. We must point the babylon submodule in this PR to your https://github.com/babylonlabs-io/babylon/tree/feat/permissioned-integration branch. Will do the change and confirm. |
fb898fc
to
5da7617
Compare
Yes, it works now. After merging the other PR, we can change the submodule ref to the |
Hmm thanks for finding this out. We can change to use base branch after mering the permissioned integrtaion PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
A small follow-up to #87.
cargo gen-proto
is failing btw. @SebastianElvis can you take a look?