Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: op consumer chain slashing (2/2) #98

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Conversation

parketh
Copy link
Collaborator

@parketh parketh commented Dec 12, 2024

Summary

This is a follow-on PR from #92 (implement slashing for op stack consumer chains)

It updates the EquivocationEvidence msg to match the latest Babylon update

Test plan

# build the contract
cargo build
cargo optimize

# test it
cargo test
cargo integration

@parketh parketh requested review from SebastianElvis, bap2pecs and lesterli and removed request for SebastianElvis December 12, 2024 08:10
},
}

pub type BabylonSudoMsg = Empty;
pub type BabylonQuery = Empty;
pub type Bytes = Vec<u8>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is necessary 😓

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i followed the same struct definition as in babylon node. do you mean we should remove the alias here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I was suggesting to remove it as there are many Bytes definitions in various libraries already. No strong objection though

@parketh parketh merged commit 3e9f03d into main Dec 19, 2024
3 checks passed
@parketh parketh deleted the feat/opcc-slashing-2 branch December 19, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants