Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Mint rewards to the finality contract #69

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

maurolacy
Copy link
Contributor

@maurolacy maurolacy commented Dec 11, 2024

Fixes the minted rewards recipient address as discussed in / required by babylonlabs-io/babylon-contract#97.

Note: Remember to update the relevant Babylon e2e test as well after this is released / integrated.

@SebastianElvis
Copy link
Member

Would you mind if we merge this after #68? I will make it ready for review tmr

@maurolacy maurolacy force-pushed the fix/rewards-generation-rcpt branch from 37f21e8 to b2fdb44 Compare December 14, 2024 15:20
@maurolacy maurolacy changed the base branch from main to integration-e2e-test-3 December 14, 2024 15:20
@maurolacy maurolacy force-pushed the fix/rewards-generation-rcpt branch from bad0eeb to 8ec4b74 Compare December 15, 2024 15:37
Copy link
Member

@SebastianElvis SebastianElvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ci failed though

Base automatically changed from integration-e2e-test-3 to main December 16, 2024 07:23
@maurolacy
Copy link
Contributor Author

maurolacy commented Dec 16, 2024

lgtm, ci failed though

Yeah, there was a silly bug in the contracts. That kept me busy for some time 🙂. Pushing a fix.

@maurolacy maurolacy force-pushed the fix/rewards-generation-rcpt branch from 8ec4b74 to b1e5302 Compare December 16, 2024 07:50
@maurolacy maurolacy merged commit 82fc98b into main Dec 16, 2024
13 checks passed
@maurolacy maurolacy deleted the fix/rewards-generation-rcpt branch December 16, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants