fix: handle rewarding give out reward to finalized blocks with gaps o…

…f unfinalized blocks
babylonlabs-io · Jan 3, 2025 · 10b90f8 · 10b90f8
1 parent a6ebbf9
commit 10b90f8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/x/finality/keeper/rewarding.go b/x/finality/keeper/rewarding.go
@@ -30,10 +30,9 @@ func (k Keeper) HandleRewarding(ctx context.Context, targetHeight int64) {
 		if err != nil {
 			panic(err)
 		}
-		if !block.Finalized {
-			break
+		if block.Finalized {
+			k.rewardBTCStaking(ctx, height)
 		}
-		k.rewardBTCStaking(ctx, height)
 		nextHeightToReward = height + 1
 	}
 

diff --git a/x/finality/keeper/rewarding_test.go b/x/finality/keeper/rewarding_test.go
@@ -153,8 +153,13 @@ func TestHandleRewardingWithGapsOfUnfinalizedBlocks(t *testing.T) {
 	})
 	fKeeper.SetVotingPowerDistCache(ctx, 3, dc)
 
+	iKeeper.EXPECT().
+		RewardBTCStaking(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).
+		Return().
+		Times(1) // number of finalized blocks processed
+
 	fKeeper.HandleRewarding(ctx, 3)
 
 	actNextBlockToBeRewarded := fKeeper.GetNextHeightToReward(ctx)
-	require.Equal(t, 4, actNextBlockToBeRewarded)
+	require.Equal(t, uint64(4), actNextBlockToBeRewarded)
 }