-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync from main to base/consumer-chain-support #303
Open
github-actions
wants to merge
61
commits into
base/consumer-chain-support
Choose a base branch
from
main
base: base/consumer-chain-support
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Root cause of babylonlabs-io/finality-provider#121. If response is nil due to error, will cause panic
Closes #263. In particular, - ensure `checkpointFinalizationTimeout` can never be changed in the update params handler of the btccheckpoint module - ensure `minUnbondingTime` can not be set to a value less than or equal to `checkpointFinalizationTimeout` in the update params handler of the btcstaking module - allows `unbondingTime` of a delegation to be set to a value equals to `minUnbondingTime`
This PR introduces the `ResumeFinalityProposal` and implements the handler, which is part of [ADR-32](babylonlabs-io/pm#95). This part is quite independent and the algorithm of choosing finality providers to jail can be implemented in the future
Updates cosmos math. [Issue](GHSA-7225-m954-23v7)
(docker)resolve Dockerfile issue & fix CVEs
The bug is caused due to setting `params.MinStakingTime` to the btcstaking module's keeper method `VerifyInclusionProofAndGetHeight` other than `params.MinUnbondingTime`. In the fix, we remove `minUnbondingTime` from the parameter list of `VerifyInclusionProofAndGetHeight` as it should retrieve the parameter within the method. This PR also added comprehensive tests for `VerifyInclusionProofAndGetHeight`
- Enforces that unbonding tx always have version `2`
Adds the ability to specify custom address to separate operational and rewards address [References ADR-036](babylonlabs-io/pm#133)
Co-authored-by: RafilxTenfen <[email protected]>
- Changes `min_unbonding_time_blocks` parameter to exact `unbonding_time` to be fully in line with phase-1 unbonding transactions
- EOI created delegations parameter version should be the some one for given block range
With recent changes: - enforcing that `min_unbonding_time` is always larger than `checkpoint_finalization_timeout` - changing `min_unbonding_time` to exact `unbonding_time` `GetStatus` can now rely on `UnbondingTime` in delegation instead of `checkpoint_finalization_timeout`
Closes #259. Using gauge is not easy to fix the issue as we don't know the number of fps being jailed. Therefore, this PR fixed the issue by adding a separate counter for unjailed fps.
- fixes genesis validation
- Fixes config linter config
- enables more linters from golang ci lint - fixes some low hanging fruits
Adds initial scaffold for tests which enable full execution of the block by comet-bft utilities: - `BlockExecutor` Those are test can be used in various scenarios: - e2e application test asserting that after certain ordered operations, we reached expected state - deterministic execution tests i.e execute some random operations and replay them and check that app hash matches - early block execution tests (if we introduce other backends than memdb)
- Helps to convert keys from pub key ```shell babylond debug pubkey-raw "A2h06lj/GAPW1RvJE3HU9yetMGCR9K7a+tcwwTYT8t7z" Parsed key as secp256k1 Address: 3565AEBC1D0CF089A4C2B04500EFE5007701604E JSON (base64): {"type":"tendermint/PubKeySecp256k1","value":"A2h06lj/GAPW1RvJE3HU9yetMGCR9K7a+tcwwTYT8t7z"} Bech32 Acc: bbnpub1addwnpepqd58f6jcluvq84k4r0y3xuw57un66vrqj862akh66ucvzdsn7t00x5n57a8 Bech32 Validator Operator: bbnvaloperpub1addwnpepqd58f6jcluvq84k4r0y3xuw57un66vrqj862akh66ucvzdsn7t00x4p4spq Bech32 Validator Consensus: BIP340 Hex: 036874ea58ff1803d6d51bc91371d4f727ad306091f4aedafad730c13613f2def3 ```
Pr changes way how babylon choses parameters for pre-approval flow - parameters will be chosen by BTC LC tip - to avoid attacks in which somebody will first send tx to BTC and then report it as EOI, additional validation during activation is added to check that staking transaction is included after the BTC LC tip during delegation creation.
Add determinism test for whole staking activation flow pending/verified/active Next steps: - finalizing epochs - finality provider voting and randomness registration
The voting power table is a map which causes random order of processing jailing events. If more than one fps jailed at one block, non-determinism could happen. The PR fixed this by introducing ordered voting power table which retains the order from interating the `votingPowerBbnBlockHeightStore`
- Add fuzzing test case for jailing being deterministc
- Move `PrivateSigner` to specific package - Created vars for constant used Mod accounts in appparams
`EndBlocker` -> `BeginBlocker` in BeginBlocker section
- enable more lints
There has been an issue relative to babylonlabs-io/finality-provider#231 and this pr adds `MsgSetWithdrawAddress` to the necessary codec file plus adds it to `types/msg.go`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR synchronizes changes from main to base/consumer-chain-support.