-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: remove e2e related to BTC staking integration #339
e2e: remove e2e related to BTC staking integration #339
Conversation
Taking a look at this. What about the e2e tests that depend on babylon? Are you adding a babylon container as a dep / tool in the Related / follow-up to this: at some point it would be good to change the docker images handling / building model (i.e. the Docker section in https://github.com/babylonlabs-io/pm/issues/118). |
@@ -168,5 +168,5 @@ func (s *IBCTransferTestSuite) Test2IBCTransferBack() { | |||
// Check that the balance of the native denom has increased | |||
return math.Abs(float64(balanceA.Add(nativeCoin).AmountOf(nativeDenom).Int64()- | |||
balanceA2.AmountOf(nativeDenom).Int64())) < delta | |||
}, 15*time.Second, 1*time.Second, "Transfer back B was not successful") | |||
}, 1*time.Minute, 1*time.Second, "Transfer back B was not successful") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼Less is more.
Yes, there is a dockerfile for babylon node in the Babylon SDK PR. I'd say that this is less ideal as 1) we might need to refer to a branch rather than a tag for non-tagged changes, and 2) everytime the CI needs to build this image
Yes, totally agreed on this. Ideally we need a docker registry for all these docker images |
Part of babylonlabs-io/babylon-sdk#64
This PR removes all e2e tests related to BTC staking integration. These tests will then be put in babylon-sdk repository (PR)