fix: remove unused deps in .proto files
#355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesterli
requested review from
Lazar955,
samricotta,
SebastianElvis,
maurolacy and
bap2pecs
and removed request for
a team,
Lazar955 and
samricotta
maurolacy
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
LGTM.
Adding the proto-lint target as part of protobuf generation or in CI tests looks like a good idea.
In particular since buf is failing on the Rust side because of these unneeded imports (see babylonlabs-io/babylon-contract#101). And in general because it's good practice.
yes, added. If needed, i can also commit a separate PR to update the |
maurolacy
reviewed
Dec 18, 2024
|
Yes, we can backport this to main branch as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes unused dependencies in
.protofiles, addressing the protobuf generation issue outlined in babylon-contract/issues/101.Test Plan