Sync from main to base/consumer-chain-support #439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
feat: merge base branch to main
- Migrates the minimal amount of code needed from the [relayer](https://github.com/cosmos/relayer) repo - Removes dependency for `cosmos/relayer` - Removes dependency for `strangelove-ventures/cometbft-client` ~Todo:~ - ~As this is modified code from the [relayer](https://github.com/cosmos/relayer), what license if any should we include in the header of those files? I've also modified them (deleted a bunch of stuff, and added more code quality improvements)~ - ~Is feegrant.go needed, feels like it can be removed and other parts related to it~ - ~Future PRs can remove references to strangelove cometbft client, tho we do have to satisfy the `CometRPC interface`, `ABCIClient interface` etc. (not sure if it's worth the extra effort)~ - ~Decide on the name of the relayer package, the clients would currently use `relayerclient.Whatever`~ [Closes](babylonlabs-io/pm#149)
github-actions
bot
requested review from
SebastianElvis,
maurolacy and
gusin13
|
@SebastianElvis can we remove this bot? |
|
@babylon-devops Could we remove base/consumer-chain-support branch given that it's already merged to |
All of our modules in proto have `/proto/babylon/<module-name>/v1/files` but incentives does not have `v1` it is defined as `/proto/babylon/incentive/files` Future investigation to try to add `v1` to the incentive proto will be done at #442
Fixes: babylonlabs-io/pm#159 We will reject BTC forks, if the first header is already known. This is consensus breaking change, but on our testnet it should be non-breaking as our vigilante reporter always reports only new btc headers prefix/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR synchronizes changes from main to base/consumer-chain-support.