Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Connect stories #143

Merged
merged 6 commits into from
Dec 19, 2024
Merged

feat: Connect stories #143

merged 6 commits into from
Dec 19, 2024

Conversation

gbarkhatov
Copy link
Contributor

Adds 2 more stories:

Useful for manual testing wallets methods and properties

Keplr will be in another PR and not a priority as of today. Created an issue for that:
#142

Copy link
Collaborator

@jrwbabylonlab jrwbabylonlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is storybook only right?
Could i confirm this won't be included in the package build?

Copy link
Collaborator

@totraev totraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be simplified

src/components/WalletProvider/index.stories.tsx Outdated Show resolved Hide resolved
src/components/WalletProvider/index.stories.tsx Outdated Show resolved Hide resolved
src/components/WalletProvider/index.stories.tsx Outdated Show resolved Hide resolved
@totraev
Copy link
Collaborator

totraev commented Dec 19, 2024

This is storybook only right? Could i confirm this won't be included in the package build?

@jrwbabylonlab Correct

@gbarkhatov
Copy link
Contributor Author

@jrwbabylonlab this is manual for storybook, correct. It allows to easily verify both wallets data and BTC wallet functionality (signPsbt, signMessage)

@gbarkhatov gbarkhatov requested a review from totraev December 19, 2024 16:51
@gbarkhatov gbarkhatov merged commit e7065aa into main Dec 19, 2024
1 check passed
@gbarkhatov gbarkhatov deleted the feat/connect-story branch December 19, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants