bump babylon v18 #102
Merged
bump babylon v18 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
KonradStaniec
commented
Dec 5, 2024
KonradStaniec
commented
- bumps babylon to v18
- fixes incompatibilites
- used parameters based on inclusion block height to build delegations
gitferry
approved these changes
Dec 5, 2024
babylonclient/babyloncontroller.go
Outdated
Comment on lines
254
to
272
| var stakingTrackerParams *StakingTrackerResponse | ||
| if err := retry.Do(func() error { | ||
| trackerParams, err := bc.QueryStakingTrackerByBtcHeight(btcHeight) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| stakingTrackerParams = trackerParams | ||
| return nil | ||
| }, RtyAtt, RtyDel, RtyErr, retry.OnRetry(func(n uint, err error) { | ||
| bc.logger.WithFields(logrus.Fields{ | ||
| "attempt": n + 1, | ||
| "max_attempts": RtyAttNum, | ||
| "error": err, | ||
| }).Error("Failed to query babylon client for staking tracker params") | ||
| })); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return stakingTrackerParams, nil |
There was a problem hiding this comment.
seems can by refactored by a bc.stakingTrackerByBtcHeightWithRetry
Comment on lines
+218
to
+233
| if err := retry.Do(func() error { | ||
| trackerParams, err := bc.QueryStakingTrackerByBtcHeight(btcHeight) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| stakingTrackerParams = trackerParams | ||
| return nil | ||
| }, RtyAtt, RtyDel, RtyErr, retry.OnRetry(func(n uint, err error) { | ||
| bc.logger.WithFields(logrus.Fields{ | ||
| "attempt": n + 1, | ||
| "max_attempts": RtyAttNum, | ||
| "error": err, | ||
| }).Error("Failed to query babylon client for staking tracker params") | ||
| })); err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
seems can by refactored by a bc.stakingTrackerByBtcHeightWithRetry
babylonclient/interface.go
Outdated
| Params() (*StakingParams, error) | ||
| ParamsByBtcHeight(btcHeight uint32) (*StakingParams, error) | ||
| StakingTrackerByBtcHeight(btcHeight uint32) (*StakingTrackerResponse, error) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.