chore: add btc wallet name to connection config #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafilxTenfen
commented
Aug 16, 2024
walletcontroller/client.go
Outdated
| @@ -75,6 +77,7 @@ func NewRpcWalletControllerFromArgs( | |||
| // we use post mode as it sure it works with either bitcoind or btcwallet | |||
| // we may need to re-consider it later if we need any notifications | |||
| HTTPPostMode: true, | |||
| Params: params.Name, | |||
There was a problem hiding this comment.
Not sure if this was needed, but I saw during debug that it was going to the fallthrough option if not set
// btcd/rpcclient/infrastructure.go
// Default network is mainnet, no parameters are necessary but if mainnet
// is specified it will be the param
switch config.Params {
case "":
fallthrough
case chaincfg.MainNetParams.Name:
client.chainParams = &chaincfg.MainNetParams
case chaincfg.TestNet3Params.Name:
client.chainParams = &chaincfg.TestNet3Params
case chaincfg.RegressionNetParams.Name:
client.chainParams = &chaincfg.RegressionNetParams
case chaincfg.SimNetParams.Name:
client.chainParams = &chaincfg.SimNetParams
default:
return nil, fmt.Errorf("rpcclient.New: Unknown chain %s", config.Params)
}
There was a problem hiding this comment.
yea, the problem is the upstream btcd, does not support signet. So if:
- we do not specify it then for
signetwe will run with&chaincfg.MainNetParamswhich for most cases is fine. Though it may, have some weird behaviour when decoding/encoding addresses - if we do specify it then for
signetstaker will not start
For now in most of our programs, we do not specify it so that we are always able to start the programs on signet.
There was a problem hiding this comment.
removed at c6d6b37
walletcontroller/client.go
Outdated
| @@ -75,6 +77,7 @@ func NewRpcWalletControllerFromArgs( | |||
| // we use post mode as it sure it works with either bitcoind or btcwallet | |||
| // we may need to re-consider it later if we need any notifications | |||
| HTTPPostMode: true, | |||
| Params: params.Name, | |||
There was a problem hiding this comment.
yea, the problem is the upstream btcd, does not support signet. So if:
- we do not specify it then for
signetwe will run with&chaincfg.MainNetParamswhich for most cases is fine. Though it may, have some weird behaviour when decoding/encoding addresses - if we do specify it then for
signetstaker will not start
For now in most of our programs, we do not specify it so that we are always able to start the programs on signet.
…ost url without wallet
KonradStaniec
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.