Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add withdrawal command #27

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Add withdrawal command #27

merged 1 commit into from
Aug 30, 2024

Conversation

KonradStaniec
Copy link
Collaborator

Add command to build withdraw transactions and psbt packet

@KonradStaniec KonradStaniec requested review from a team, Lazar955 and RafilxTenfen and removed request for a team August 29, 2024 09:14
Comment on lines 804 to 806
func outputsAreEqual(a *wire.TxOut, b *wire.TxOut) bool {
if a.Value != b.Value {
return false
}

if !bytes.Equal(a.PkScript, b.PkScript) {
return false
}

return true
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func outputsAreEqual(a *wire.TxOut, b *wire.TxOut) bool {
if a.Value != b.Value {
return false
}
if !bytes.Equal(a.PkScript, b.PkScript) {
return false
}
return true
}
func outputsAreEqual(a, b *wire.TxOut) bool {
return a.Value == b.Value && bytes.Equal(a.PkScript, b.PkScript)
}

var createPhase1WithdrawalTransactionCmd = cli.Command{
Name: "create-phase1-withdrawal-transaction",
ShortName: "crpwt",
Usage: "stakercli transaction create-phase1-withdrawal-transactio [fullpath/to/parameters.json]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Usage: "stakercli transaction create-phase1-withdrawal-transactio [fullpath/to/parameters.json]",
Usage: "stakercli transaction create-phase1-withdrawal-transaction [fullpath/to/parameters.json]",

Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@KonradStaniec KonradStaniec force-pushed the feat/withdraw-command branch from b46542e to 008569f Compare August 30, 2024 05:37
@KonradStaniec KonradStaniec merged commit 1fad96a into main Aug 30, 2024
8 checks passed
@KonradStaniec KonradStaniec deleted the feat/withdraw-command branch August 30, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants