fix: pre approval flow fixes #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonradStaniec
force-pushed
the
konradstaniec/pre-approval-fixes
branch
from
0652e9f to
49640ac
Compare
Lazar955
approved these changes
Oct 15, 2024
| stakingOutputIndex uint32, | ||
| stakingTime uint16, | ||
| fpPubKeys []*btcec.PublicKey, | ||
| pop *ProofOfPossession, |
There was a problem hiding this comment.
might be useful to check pop is not nil to avoid nil pointer
stakerdb/trackedtranactionstore.go
Outdated
| return nil, fmt.Errorf("cannot add transaction without finality providers public keys") | ||
| } | ||
|
|
||
| var fpPubKeysBytes [][]byte = make([][]byte, len(fpPubKeys)) |
There was a problem hiding this comment.
Suggested change
| var fpPubKeysBytes [][]byte = make([][]byte, len(fpPubKeys)) | |
| fpPubKeysBytes := make([][]byte, len(fpPubKeys)) |
No need to be redundant with type declaration
stakerdb/trackedtranactionstore.go
Outdated
| } | ||
|
|
||
| return c.addTransactionInternal( | ||
| txHashBytes, &msg, nil, |
There was a problem hiding this comment.
Suggested change
| txHashBytes, &msg, nil, | |
| txHash[:], &msg, nil, |
stakerdb/trackedtranactionstore.go
Outdated
| serializedTx, err := utils.SerializeBtcTransaction(btcTx) | ||
|
|
||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
Suggested change
| return err | |
| return fmt.Errorf("failed to serialize Bitcoin transaction: %w", err) |
stakerdb/trackedtranactionstore.go
Outdated
| update, err := newInitialUnbondingTxData(unbondingTx, unbondingTime) | ||
|
|
||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
Suggested change
| return err | |
| return fmt.Errorf("failed to create unbonding transaction data: %w", err) | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CREATED) to make sure staking command returns to caller only if staking tx was delivered either to Babylon or to BTC