Disallow creating new stake if allow list is enabled #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
KonradStaniec
commented
Nov 14, 2024
KonradStaniec
commented
- adjust for allow list modification in babylon v0.16.0, new stake can't be created if allow list is enabled
gitferry
reviewed
Nov 14, 2024
Comment on lines
+1794
to
+1795
| // we add +1 to account for comet bft lazy execution | ||
| if latestBlockHeight <= params.AllowListExpirationHeight+1 { |
There was a problem hiding this comment.
trying to understand this. So, this check means if AllowListExpirationHeight = 100, new delegations can be made when the latest block height is >= 102. Is this expected? I thought new delegations should be able to be made if latest block height is >=100 as they will be included in 101 which is > AllowListExpirationHeight=100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.