try fix data race

babylonlabs-io · Jan 31, 2025 · 5676080 · 5676080
1 parent af9976f
commit 5676080
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/finality-provider/service/fp_store_adapter.go b/finality-provider/service/fp_store_adapter.go
@@ -51,7 +51,13 @@ func (fps *fpState) setLastVotedHeight(height uint64) error {
 }
 
 func (fp *FinalityProviderInstance) GetStoreFinalityProvider() *store.StoredFinalityProvider {
-	return fp.fpState.sfp
+	var sfp *store.StoredFinalityProvider
+	fp.fpState.withLock(func() {
+		// Create a copy of the stored finality provider to prevent data races
+		sfpCopy := *fp.fpState.sfp
+		sfp = &sfpCopy
+	})
+	return sfp
 }
 
 func (fp *FinalityProviderInstance) GetBtcPkBIP340() *bbntypes.BIP340PubKey {