chore: add finality activation height #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RafilxTenfen
commented
Oct 19, 2024
•
RafilxTenfen
commented
- Add checks for finality activation height
- Pub rand commit start height at activation height or last commited height whatever is higher
- Finality vote, only vote in blocks after the finality activation height
- Update babylon to v014
…sumer client controller
RafilxTenfen
changed the title
KonradStaniec
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
In general looks good 👍 though lets wait for @gitferry review
gitferry
reviewed
Oct 24, 2024
| @@ -395,6 +389,18 @@ func (fp *FinalityProviderInstance) tryFastSync(targetBlock *types.BlockInfo) (* | |||
| return fp.FastSync(startHeight, targetBlock.Height) | |||
| } | |||
|
|
|||
| func (fp *FinalityProviderInstance) fastSyncStartHeight(lastFinalizedHeight uint64) (uint64, error) { | |||
There was a problem hiding this comment.
fastSyncStartHeight is called after we have known that there's finalized blocks, indicating that activation is already started, so maybe we don't need to check activation height here?
There was a problem hiding this comment.
fastSyncStartHeight returns the height that fast sync should start right?
I probably can remove the check inside the fastSync than
Yeap, you are right, there was another loop that sends finality, check added at 7175eba |
gitferry
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.