Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow to create keys with empty hd path #148

Merged
merged 7 commits into from
Nov 22, 2024
Merged

fix: allow to create keys with empty hd path #148

merged 7 commits into from
Nov 22, 2024

Conversation

RafilxTenfen
Copy link
Contributor

  • Copy the keys add command from cosmos-sdk just modified to allow empty HD path (The choice to continue to use the SDK is due the rest of the commands import/export work as expected)
  • Move cmd files from package main to eotsd, it helps to debbug

@RafilxTenfen RafilxTenfen self-assigned this Nov 22, 2024
@RafilxTenfen RafilxTenfen linked an issue Nov 22, 2024 that may be closed by this pull request
CLI eotsd keys import/export #20
Closed
@RafilxTenfen RafilxTenfen removed a link to an issue Nov 22, 2024
CLI eotsd keys import/export #20
Closed
@RafilxTenfen RafilxTenfen linked an issue Nov 22, 2024 that may be closed by this pull request
Revert change of using Cosmos SDK keyring for key creation #143
Closed
@RafilxTenfen RafilxTenfen marked this pull request as ready for review November 22, 2024 01:20
gitferry
gitferry approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@gitferry gitferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

eotsmanager/cmd/eotsd/daemon/keysadd.go Show resolved Hide resolved
eotsmanager/cmd/eotsd/daemon/keysadd.go Show resolved Hide resolved
@RafilxTenfen RafilxTenfen merged commit 3117772 into main Nov 22, 2024
12 checks passed
@RafilxTenfen RafilxTenfen deleted the rafilx/fix-add-keys-empty-hdpath branch November 22, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitferry gitferry gitferry approved these changes

@filippos47 filippos47 Awaiting requested review from filippos47

@samricotta samricotta Awaiting requested review from samricotta

Assignees

@RafilxTenfen RafilxTenfen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert change of using Cosmos SDK keyring for key creation
2 participants
@RafilxTenfen @gitferry