fix: shouldn't wait SubmissionRetryInterval at the first iteration
#217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bap2pecs
requested review from
SebastianElvis,
gitferry,
lesterli,
maurolacy,
parketh and
gusin13
and removed request for
SebastianElvis
lesterli
approved these changes
Dec 12, 2024
|
will let @gitferry @SebastianElvis take a second look before I merge |
gitferry
approved these changes
Dec 16, 2024
|
bap2pecs
added a commit
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
we found an issue in our OP devnet that finality sigs were submitted very slow. the root cause is we shouldn't wait 300 seconds in the first iteration in the for loop inside
retrySubmitSigsUntilFinalized()more context: #155 (comment)
Test Plan
tested in our devnet with the new image
set
PollIntervalto 0.5 sec and see how it "fast synced" to the latest block