chore: Enable gosec and fix findings #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update involves:
- Enabling gosec in the github workflow and updating
the github workflow versions.
- Update the codebase to fix findings from gosec. Highlights:
- Some unhandled errors
- Config types allowed for very large values. For example,
the retry intervals and the commit gaps allowed for uint64.
All values related to block sizes were left to uint64, but
the others were reduced to uint32.
- Prometheus server protection against Slowloris
vitsalis
force-pushed
the
types-and-gosec
branch
from
4c6b0a0 to
99a8dd4
Compare
KonradStaniec
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update involves: