fix: CI failed to run the op e2e tests #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how did you test this PR? not sure if I am missing anything but it still says "no test to run"
|
yes, I tested it locally, all tests are passed.
it is werid |
hmm that's not the right way to test PR like this. to test CI, you need to check if the CI does what it's supposed to do -- by examining the logs :) |
|
Discussed offline. FILTER is probably the root cause. let's
|
SebastianElvis
approved these changes
Oct 15, 2024
Comment on lines
115
to
120
| test-e2e-op: clean-e2e install-babylond | ||
| @go test -mod=readonly -timeout=25m -v $(PACKAGES_E2E_OP) -count=1 --tags=e2e_op | ||
|
|
||
| FILTER ?= . | ||
| test-e2e-op-filter: clean-e2e install-babylond | ||
| @go test -mod=readonly -timeout=25m -v $(PACKAGES_E2E_OP) -count=1 --tags=e2e_op --run ^$(FILTER)$ |
There was a problem hiding this comment.
Good idea on having FILTER for testing certain case 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
e2e_opjob to set up the devnet data for OP e2e tests, addressing the issue where the devnet data does not exist. fix: op e2e test #76 (comment)e2e_opjob issue: "no test to run"Test Plan
To trigger the CI to check if the op e2e tests work fine.