fix: prefix FP url with https if no protocol present #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jrwbabylonlab
commented
Aug 26, 2024
jrwbabylonlab
commented
jrwbabylonlab
requested review from
vitsalis,
gbarkhatov and
jeremy-babylonlabs
jrwbabylonlab
force-pushed
the
prefix-fp-with-protocols-if-not-exist
branch
from
40b1c09 to
8dd2bd7
Compare
|
Recommend that finality providers provide proper information instead of us cleaning invalid information they provided. In the future, we'll look out to not merge such PRs. For me, this change just complicates the codebase. I would be much happier with just not displaying the URL if it is not a proper one. |
gbarkhatov
approved these changes
Aug 26, 2024
|
close the PR In favour of this #116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.