add points UI #125
Merged
add points UI #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-babylonlabs
requested review from
gbarkhatov,
jrwbabylonlab,
vitsalis and
totraev
and removed request for
gbarkhatov and
jrwbabylonlab
Desktop
Mobile
Major changes:
TODO:
|
vitsalis
reviewed
Sep 7, 2024
jeremy-babylonlabs
force-pushed
the
feat/points
branch
from
d6a1635 to
0a9883e
Compare
jeremy-babylonlabs
force-pushed
the
feat/points
branch
from
0a9883e to
6c58093
Compare
jeremy-babylonlabs
force-pushed
the
feat/points
branch
from
6c58093 to
ac2bbd0
Compare
|
hmm... why is PR closed? |
|
i think i misclicked it on mobile |
jeremy-babylonlabs
force-pushed
the
feat/points
branch
from
21185c8 to
96748be
Compare
totraev
previously requested changes
Sep 10, 2024
gbarkhatov
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
@jeremy-babylonlabs I like the loading placeholder
Though each time I switch to another tab and come back, it will be loading again: https://i.imgur.com/SRp80pc.png
What do you guys think about this UX? We can make it load once per X amount of time, or leave it as it is @vitsalis @jrwbabylonlab
@jeremy-babylonlabs overall really good work, I approve it from my side since the comments are minor and this implementation suits our needs at the moment
@jeremy-babylonlabs the style seems broken on the delegation list
also the query params is wrong with `[]` in the url
One thing i think might be concerning from design point of view is that the fetching of points by individual staking tx has may result in a large num of requests to backend if staker have a lot of delegations. Let's discuss this on the zoom on the best way to optimise this.
This staking summary part is different to the figma design, has this been communicated to use this new UX design or it's a mistake? |
vitsalis
reviewed
Sep 12, 2024
gbarkhatov
reviewed
Sep 12, 2024
jeremy-babylonlabs
dismissed stale reviews from gbarkhatov and totraev
resolved
jrwbabylonlab
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.