Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mobile layout for Connect Modal #130

Merged
merged 3 commits into from
Sep 11, 2024
Merged

fix: mobile layout for Connect Modal #130

merged 3 commits into from
Sep 11, 2024

Conversation

0xDazzer
Copy link
Contributor

@0xDazzer 0xDazzer commented Sep 9, 2024 •
edited
Loading

Major changes

  • was fixed header and footer sections to the top and bottom of the modal correspondingly
  • added tailwind-merge lib
  • added postcss-import plugin for postcss and fixed issue with global styles

Before

Screenshot 2024-09-10 at 17 56 23 Screenshot 2024-09-10 at 17 56 41

After

Screenshot 2024-09-10 at 17 55 15 Screenshot 2024-09-10 at 17 54 49

@0xDazzer 0xDazzer linked an issue Sep 9, 2024 that may be closed by this pull request
Connect wallet scrollable area and button #74
Closed
@gbarkhatov
Copy link
Contributor

@totraev please add

  • description
  • screenshots (before an after) for such PRs so it's easier to navigate later on

@gbarkhatov
Copy link
Contributor

@totraev if you plan to use tailwind-merge @ ping me to re-review

@0xDazzer 0xDazzer force-pushed the 74-connect-wallet-scrollable-area-and-button branch from 6b22c6a to ba8daba Compare September 10, 2024 12:34
@0xDazzer 0xDazzer requested a review from gbarkhatov September 10, 2024 12:38
@0xDazzer 0xDazzer merged commit c8104f6 into dev Sep 11, 2024
1 check passed
@0xDazzer 0xDazzer deleted the 74-connect-wallet-scrollable-area-and-button branch September 11, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbarkhatov gbarkhatov gbarkhatov approved these changes

@jrwbabylonlab jrwbabylonlab jrwbabylonlab approved these changes

@jeremy-babylonlabs jeremy-babylonlabs jeremy-babylonlabs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connect wallet scrollable area and button
4 participants
@0xDazzer @gbarkhatov @jrwbabylonlab @jeremy-babylonlabs